Add router tests for /assets/ access control#679
Merged
perber merged 3 commits intofix/assets-are-public-accessiblefrom Feb 11, 2026
Merged
Add router tests for /assets/ access control#679perber merged 3 commits intofix/assets-are-public-accessiblefrom
/assets/ access control#679perber merged 3 commits intofix/assets-are-public-accessiblefrom
Conversation
Co-authored-by: perber <6125824+perber@users.noreply.github.com>
Co-authored-by: perber <6125824+perber@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix public access issue for
Add router tests for Feb 11, 2026
/assets/ based on review/assets/ access control
perber
added a commit
that referenced
this pull request
Feb 11, 2026
#678) * fix: `/assets/` is publicly accessible when when public access is disabled * Update internal/http/router.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add router tests for `/assets/` access control (#679) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new conditional
/assets/routing (public whenPublicAccess/AuthDisabled, auth-required otherwise) lacked test coverage for the static file route itself.Changes
uploadTestAsset()creates page, uploads asset, handles auth/CSRF tokensEach test verifies both status code and file content to ensure the routing logic in
router.go:61-72prevents unauthorized access regressions.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.